Cleanup the dependencies in rclcpp_components.#2918
Merged
clalancette merged 1 commit intorollingfrom Aug 4, 2025
Merged
Conversation
The most important change in here is the changes to the package.xml
and the CMakeLists.txt, which now properly export the dependencies
to downstream packages as required. On those two fronts:
1. Make sure to add a dependency on rmw, which this package does depend
on for rmw_request_id_t
2. Make sure to add a dependency on rcl_interfaces, which this package
also depends on.
3. Export depend class_loader, composition_interfaces, rclcpp,
rcpputils, and rmw, all of which are exported in the header files.
4. Remove the unnecessary test dependencies on launch_testing and
std_msgs, neither of which is used.
The rest of the change here is to cleanup the header files to include
what you use everywhere.
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
fujitatomoya
approved these changes
Aug 1, 2025
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI.
Collaborator
|
Pulls: #2918
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The most important change in here is the changes to the package.xml and the CMakeLists.txt, which now properly export the dependencies to downstream packages as required. On those two fronts:
The rest of the change here is to cleanup the header files to include what you use everywhere.
Is this user-facing behavior change?
Not really. There is some possibility that a downstream package was inadvertently relying on this package to export
ament_index_cppto it, but it is a minor point.Did you use Generative AI?
No.
Additional Information
N/A