[kilted] Expose typesupport_helpers API needed for the Rosbag2 (backport #2858)#2901
Merged
MichaelOrlov merged 1 commit intokiltedfrom Jul 14, 2025
Merged
[kilted] Expose typesupport_helpers API needed for the Rosbag2 (backport #2858)#2901MichaelOrlov merged 1 commit intokiltedfrom
typesupport_helpers API needed for the Rosbag2 (backport #2858)#2901MichaelOrlov merged 1 commit intokiltedfrom
Conversation
* Expose extract_type_identifier and get_typesupport_library_path API - Rationale: We need to use this API in the Rosbag2 - Reference PR ros2/rosbag2#2017 in the Rosbag2 Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Use C++ style in doxygen documentation Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit 448287b)
typesupport_helpers API needed for the Rosbag2 (backport #2858)typesupport_helpers API needed for the Rosbag2 (backport #2858)
MichaelOrlov
approved these changes
Jul 10, 2025
Contributor
|
Pulls: #2901
|
Contributor
|
Pulls: #2901
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
extract_type_identifier(const std::string & full_type)andget_typesupport_library_path( const std::string & package_name, const std::string & typesupport_identifier)API to be publicly available for usage from other packages.Rationale:
extract_type_identifier(const std::string & full_type)andget_typesupport_library_path( const std::string & package_name, const std::string & typesupport_identifier)API from the RCLCPP package in order to get rid of the code duplication and possible implementation divergences in the future for the same utility functions.Please refer to the relevant Rosbag2 PR Use rclcpp type support helpers in rosbag2_cpp rosbag2#2017
Fixes # (issue) N/A
Is this user-facing behavior change?
No.
Did you use Generative AI?
Yes. Github Copilot, GPT-4.1, to help write Doxygen comments for the API.
Additional Information
This is an automatic backport of pull request #2858 done by [Mergify](https://mergify.com).