make sure that plugin arg includes the double colon.#2878
Merged
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
commented
Jun 24, 2025
Comment on lines
+60
to
+62
| if("${ARGS_PLUGIN}" MATCHES "^[^:]+:[^:]+$") | ||
| message(FATAL_ERROR "PLUGIN argument '${ARGS_PLUGIN}' appears to be incorrect. (e.g., 'package_name::ClassName').") | ||
| endif() |
Collaborator
Author
There was a problem hiding this comment.
This can detect the missing colon in the plugin argument as reported on ros2/ros2_documentation#5745.
I am still not sure if this is appropriate approach, but it actually checks the missing colon at build time.
root@tomoyafujita:~/ros2_ws/colcon_ws# ros2 run action_tutorials_cpp fibonacci_action_server
^C[INFO] [1750790862.411470713] [rclcpp]: signal_handler(signum=2)
[ros2run]: Received signal: Interrupt
[INFO] [1750790862.411682265] [rclcpp]: signal_handler(signum=2)
root@tomoyafujita:~/ros2_ws/colcon_ws# colcon build --packages-select action_tutorials_cpp rclcpp
[1.236s] WARNING:colcon.colcon_core.package_selection:Some selected packages are already built in one or more underlay workspaces:
'rclcpp' is in: /root/ros2_ws/colcon_ws/install/rclcpp
If a package in a merged underlay workspace is overridden and it installs headers, then all packages in the overlay must sort their include directories by workspace order. Failure to do so may result in build failures or undefined behavior at run time.
If the overridden package is used by another package in any underlay, then the overriding package in the overlay must be API and ABI compatible or undefined behavior at run time may occur.
If you understand the risks and want to override a package anyways, add the following to the command line:
--allow-overriding rclcpp
This may be promoted to an error in a future release of colcon-override-check.
Starting >>> rclcpp
Finished <<< rclcpp [1.11s]
Starting >>> action_tutorials_cpp
--- stderr: action_tutorials_cpp
CMake Error at /root/ros2_ws/colcon_ws/install/rclcpp_components/share/rclcpp_components/cmake/rclcpp_components_register_node.cmake:61 (message):
PLUGIN argument 'action_tutorials_cpp:FibonacciActionClient' appears to be
incorrect. (e.g., 'package_name::ClassName').
Call Stack (most recent call first):
CMakeLists.txt:29 (rclcpp_components_register_node)
jmachowinski
approved these changes
Jun 24, 2025
Contributor
|
Pulls: #2878 |
ahcorde
approved these changes
Jun 25, 2025
Contributor
ahcorde
left a comment
There was a problem hiding this comment.
The windows failures looks unrelated, do you mind to take a look @fujitatomoya ?
Collaborator
Author
mihirr-NV
pushed a commit
to mihirr-NV/rclcpp
that referenced
this pull request
Jun 26, 2025
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes ros2/ros2_documentation#5745
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information