Pulls: #2877
Gist: https://gist.githubusercontent.com/fujitatomoya/4d242b9d39635a526f6c3d48427dd326/raw/c75ad2a42b7ad8d0e551b19baf352f892410f000/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16308

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

@jmachowinski Adding your last feedback the rcl_get_error_string() returns error not set. Are you fine if I restore these changes?

That's odd, this would mean rcl does not set the error correctly, is this the reason why the TODOs were there in the first place ?

I am deeply confused https://github.com/ros2/rcutils/blob/697ebd943c3438ffb9f20b64d07d1c9654a4c8d1/src/string_array.c#L68C5-L68C26
We set an error string here, why is it not returned by rcl_get_error_string ?

Ahh figured it out, this happens because the test mocks and fails rcutils_string_array_fini

I guess we need to patch the test case as well and use patch_to_fail instead of patch_and_return

TEST_F(TestNodeGraph, get_node_names_and_namespaces_fini_errors)
{
  auto mock_names_fini = mocking_utils::patch_to_fail(
    "lib:rclcpp", rcutils_string_array_fini, "string_array is null", RCL_RET_ERROR);
  RCLCPP_EXPECT_THROW_EQ(
    node_graph()->get_node_names_and_namespaces(),
    std::runtime_error("could not destroy node names, could not destroy node namespaces : string_array is null"));
}

• Linux
• Linux-aarch64
• Linux-rhel
• Windows