Conversation
With the similar rewrite coming in rcutils logging macros, this is now required (since the old machinery relied on the removed code in rcutils). Regardless, I think this is more readable and maintainable. Note that this does *not* remove the python3-empy dependency, since that is still needed for other things. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
(note that the Rpr job here is expected to fail until ros2/rcutils#502 is merged and released) |
fujitatomoya
left a comment
There was a problem hiding this comment.
This introduces basic macros like RCLCPP_STATIC_ASSERT_LOGGER and RCLCPP_LOG_TIME_POINT_FUNC to remove redundant implementation, and ensuring that documentation stays clean with copydoc doc string from basic macros to avoid describing the same docstring again and again.
lgtm with green CI.
|
Pulls: ros2/rcutils#502, #2870
|
|
This pull request has been mentioned on Open Robotics Discourse. There might be relevant details there: |
|
CI is clean here, and there were no concerns in the discourse thread, so I'm going ahead and merging in this one and ros2/rcutils#502 |
Description
With the similar rewrite coming in rcutils logging macros, this is now required (since the old machinery relied on the removed code in rcutils). Regardless, I think this is more readable and maintainable.
Note that this does not remove the python3-empy dependency, since that is still needed for other things.
Is this user-facing behavior change?
No.
Did you use Generative AI?
No.
Additional Information
Depends on ros2/rcutils#502 , so must be merged at the same time.