Skip to content

remove cancel_clock_executor_promise_.#2797

Merged
fujitatomoya merged 1 commit intorollingfrom
fujitatomoya/remove-cancel_clock_executor_promise
Apr 10, 2025
Merged

remove cancel_clock_executor_promise_.#2797
fujitatomoya merged 1 commit intorollingfrom
fujitatomoya/remove-cancel_clock_executor_promise

Conversation

@fujitatomoya
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya commented Apr 9, 2025 •
edited
Loading

see #2378 (comment)

Important

backport to humble and jazzy This is ABI breaking change, so no backports.

@fujitatomoya
remove cancel_clock_executor_promise_.
6e40bb7 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com>
fujitatomoya
fujitatomoya commented Apr 9, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmachowinski requesting review, i added you as co-author.

@fujitatomoya fujitatomoya self-assigned this Apr 9, 2025
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Apr 10, 2025

Pulls: #2797
Gist: https://gist.githubusercontent.com/ahcorde/43ec3c6ba62ff5d29dfb684958ff22db/raw/caeaadf6e9547e143e764221ac4f8023015d8323/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15653

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit 0162861 into rolling Apr 10, 2025
2 of 3 checks passed
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Apr 10, 2025

@Mergifyio backport humble jazzy

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 10, 2025 •
edited
Loading

backport humble jazzy

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Apr 10, 2025
@fujitatomoya @mergify
remove cancel_clock_executor_promise_. (#2797)
5309175 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com>
(cherry picked from commit 0162861)
@mergify mergify bot mentioned this pull request Apr 10, 2025
Closed
mergify bot pushed a commit that referenced this pull request Apr 10, 2025
@fujitatomoya @mergify
remove cancel_clock_executor_promise_. (#2797)
6238fb7 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com>
(cherry picked from commit 0162861)
@mergify mergify bot mentioned this pull request Apr 10, 2025
Closed
@Crola1702 Crola1702 mentioned this pull request Aug 7, 2025
Closed
@christophebedard christophebedard deleted the fujitatomoya/remove-cancel_clock_executor_promise branch August 14, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmachowinski jmachowinski jmachowinski approved these changes

Assignees

@fujitatomoya fujitatomoya

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fujitatomoya @ahcorde @jmachowinski