should pull valid transition before trying to change the state. (backport #2774)#2785
should pull valid transition before trying to change the state. (backport #2774)#2785
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 7b6ee8a) # Conflicts: # rclcpp_lifecycle/src/lifecycle_node_interface_impl.cpp
|
Cherry-pick of 7b6ee8a has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
ahcorde
left a comment
There was a problem hiding this comment.
Do you mind to take a look @fujitatomoya ?
|
@ahcorde @jmachowinski thanks, i will take a look at this conflict. |
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
left a comment
There was a problem hiding this comment.
code base is different, rclcpp_lifecycle/src/lifecycle_node_interface_impl.cpp does not exist in humble.
local testing succeed without any error.
|
Pulls: #2785
|
i think this is just a simple oversight.
rcl_lifecycle_get_transition_by_idshould be called to pull out the valid transition based on the current state, aligns withrcl_lifecycle_get_transition_by_label.Note
backport to humble and jazzy required
This is an automatic backport of pull request #2774 done by Mergify.