doc: Added warning to not instantiate Clock directly with RCL_ROS_TIME (backport #2768)#2769
Merged
christophebedard merged 1 commit intojazzyfrom Mar 15, 2025
Merged
Conversation
#2768) Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Signed-off-by: Janosch Machowinski <jmachowinski@users.noreply.github.com> Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 30e61c9)
fujitatomoya
approved these changes
Mar 14, 2025
Collaborator
|
Pulls: #2769
|
jplapp
pushed a commit
to pixel-robotics/rclcpp
that referenced
this pull request
Apr 9, 2025
ros2#2768) (ros2#2769) Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Signed-off-by: Janosch Machowinski <jmachowinski@users.noreply.github.com> Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 30e61c9) Co-authored-by: Janosch Machowinski <jmachowinski@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If one instantiates a clock with RCL_ROS_TIME one needs to make sure, to attach a valid time source, or the clock will fall back to system time, which is highly unexpected for users of the clock.
This is an automatic backport of pull request #2768 done by Mergify.