Executor strong reference fix (backport #2745)#2754
Merged
Conversation
#2678 reported that the executor was holding strong references to entities during execution. This commit adds a regression test for this. * fix(Executor): Don't hold strong references to entities during spin This fixes a bug, were dropping an entity during a callback would not prevent further callbacks. Note, there might still be a race in the case of the mutithreaded executor. Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com> (cherry picked from commit 9c493c4)
Contributor
|
Pulls: #2754
|
Collaborator
|
I just reran the windows build and now it shows no errors : I don't really know what to make of this, I will check the failed test with valgrind. |
Collaborator
valgrind ./add_two_ints_client_async
==760996== Memcheck, a memory error detector
==760996== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==760996== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==760996== Command: ./add_two_ints_client_async
==760996==
[INFO] [1740134787.893492135] [add_two_ints_client]: Result of add_two_ints: 5
==760996==
==760996== HEAP SUMMARY:
==760996== in use at exit: 81,717 bytes in 192 blocks
==760996== total heap usage: 30,207 allocs, 30,015 frees, 6,747,330 bytes allocated
==760996==
==760996== LEAK SUMMARY:
==760996== definitely lost: 0 bytes in 0 blocks
==760996== indirectly lost: 0 bytes in 0 blocks
==760996== possibly lost: 736 bytes in 2 blocks
==760996== still reachable: 80,981 bytes in 190 blocks
==760996== suppressed: 0 bytes in 0 blocks
==760996== Rerun with --leak-check=full to see details of leaked memory
==760996==
==760996== For lists of detected and suppressed errors, rerun with: -s
==760996== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)Valgrind shows no problems. I would say we can move ahead and say this was some fluke in the build pipeline. |
jmachowinski
approved these changes
Feb 21, 2025
alsora
approved these changes
Feb 21, 2025
Collaborator
alsora
left a comment
There was a problem hiding this comment.
CHanges look good and the windows failure seems unrelated / general flakiness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2678
@mjcarroll we should merge this ASAP and backport to jazzy, to keep the ABI breakage to one release
This is an automatic backport of pull request #2745 done by Mergify.