fix(timer): Delete node, after executor thread terminated (backport #2737)#2738
Merged
fix(timer): Delete node, after executor thread terminated (backport #2737)#2738
Conversation
This fixes a potential race leading to a segfault. The segfault would happen, if the tear down of the test would occur before the timer thread stopped the spinning of the executor. Also simplifies the test code, as the cancel of the executor is now in the TearDown(). Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com> (cherry picked from commit f6b80ab)
fujitatomoya
approved these changes
Feb 11, 2025
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
@jmachowinski can you take a look just in case?
Collaborator
|
Pulls: #2738
|
jmachowinski
approved these changes
Feb 11, 2025
ahcorde
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a potential race leading to a segfault. The segfault would happen, if the tear down of the test would occur before the timer thread stopped the spinning of the executor.
Also simplifies the test code, as the cancel of the executor is now in the TearDown().
This is an automatic backport of pull request #2737 done by Mergify.