update doc section for spin_xxx methods.#2730
Merged
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
commented
Jan 28, 2025
Collaborator
Author
fujitatomoya
left a comment
There was a problem hiding this comment.
@wjwwood @mjcarroll
CC: @kscottz
trying to clarify the behavior for spin_xxx especially the difference between them, can you take a look?
wjwwood
requested changes
Jan 28, 2025
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: William Woodall <william@osrfoundation.org>
Collaborator
Author
|
Pulls: #2730
|
Collaborator
Author
|
@wjwwood can you merge this? (i just borrowed your suggestion, and only doc fix) |
mjcarroll
approved these changes
Feb 4, 2025
Collaborator
Author
|
@mjcarroll thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2655