Skip to content

Adding in topic name to logging on IPC issues (backport #2706)#2710

Merged
fujitatomoya merged 1 commit intojazzyfrom
mergify/bp/jazzy/pr-2706
Dec 14, 2024
Merged

Adding in topic name to logging on IPC issues (backport #2706)#2710
fujitatomoya merged 1 commit intojazzyfrom
mergify/bp/jazzy/pr-2706

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Dec 14, 2024

This enables more introspection on "why" something failed so a user can fix it. Without this, migrating a node to IPC can be excruciatingly painful to find what of dozens of interfaces are having problems.

Addresses #2703


This is an automatic backport of pull request #2706 done by Mergify.

* Adding in topic name to logging on IPC issues

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update test matching output logging

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* adding in single quotes

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
(cherry picked from commit a13e16e)
@fujitatomoya
Copy link
Copy Markdown
Collaborator

Pulls: #2710
Gist: https://gist.githubusercontent.com/fujitatomoya/1b78cc77efdcec6e1d56979684e237a7/raw/a764f58b393b9319e1b4dc6df18c57a0336b2d0f/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14963

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit 608e2f2 into jazzy Dec 14, 2024
@MichaelOrlov MichaelOrlov deleted the mergify/bp/jazzy/pr-2706 branch July 29, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants