a couple of typo fixes in doc section for LoanedMessage.#2676
Merged
clalancette merged 2 commits intorollingfrom Nov 19, 2024
Merged
a couple of typo fixes in doc section for LoanedMessage.#2676clalancette merged 2 commits intorollingfrom
clalancette merged 2 commits intorollingfrom
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
commented
Nov 18, 2024
Collaborator
Author
fujitatomoya
left a comment
There was a problem hiding this comment.
@clalancette @mjcarroll is this correct English? as far as i looked up, it should be performed instead?
Member
|
"performaned" is definitely not a word |
clalancette
requested changes
Nov 18, 2024
Contributor
clalancette
left a comment
There was a problem hiding this comment.
I've left some rewrites of the wording here, which I think improves things over just the typo fixes.
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
Collaborator
Author
|
Pulls: #2676
|
ahcorde
approved these changes
Nov 19, 2024
clalancette
approved these changes
Nov 19, 2024
HarunTeper
pushed a commit
to HarunTeper/rclcpp
that referenced
this pull request
Dec 9, 2024
* rephrase doc section of LoanedMessage Class. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> Signed-off-by: HarunTeper <harun.teper@tu-dortmund.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just a couple of typo fixes.