Skip to content

Skip client_qos test#2658

Merged
clalancette merged 2 commits intoironfrom
Crola1702/disable-test-qos
Nov 5, 2024
Merged

Skip client_qos test#2658
clalancette merged 2 commits intoironfrom
Crola1702/disable-test-qos

Conversation

@Crola1702
Copy link
Copy Markdown
Contributor

@Crola1702 Crola1702 commented Oct 29, 2024 •
edited
Loading

This test is being disabling this test because we don't have allocated time to fix it, also, Iron is getting EOL soon.

Fixes: #2611

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@Crola1702
Skip client_qos test
9f62f5a 
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@fujitatomoya
fix uncrustify warning.
03332e2 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
fujitatomoya reviewed Oct 30, 2024
View reviewed changes
@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Oct 30, 2024

@Crola1702 so this problem only happens with Iron, and since Iron getting closer to E.O.L soon, just skipping the test. is my understanding correct?

@clalancette
Copy link
Copy Markdown
Contributor

clalancette commented Nov 1, 2024

@Crola1702 so this problem only happens with Iron, and since Iron getting closer to E.O.L soon, just skipping the test. is my understanding correct?

Yeah, exactly. I suggested that backporting things just to fix tests in Iron isn't a good use of time. So just to keep things quiet here, we're disabling this test on Iron (we're keeping it on Rolling, though).

@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Nov 1, 2024

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@Crola1702
Copy link
Copy Markdown
Contributor Author

Crola1702 commented Nov 5, 2024

CI again:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@clalancette
Copy link
Copy Markdown
Contributor

clalancette commented Nov 5, 2024

The latest CI here was unhappy because CI_USE_FASTRTPS_STATIC was unchecked. While this is something that technically is allowed, it doesn't work in the general case.

I'm going to rerun CI here, using all of the defaults.

@clalancette
Copy link
Copy Markdown
Contributor

clalancette commented Nov 5, 2024

Pulls: #2658
Gist: https://gist.githubusercontent.com/clalancette/b7083ca2c516e236b9611b28d6219fc2/raw/5fe210dc2dbe01324ce6f57f10961856cb5d0252/ros2.repos
BUILD args: --packages-up-to rclcpp
TEST args: --packages-select rclcpp
ROS Distro: iron
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14787

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@clalancette
Copy link
Copy Markdown
Contributor

clalancette commented Nov 5, 2024

The RHEL warnings are unrelated, merging.

@clalancette clalancette merged commit 1f9e5e8 into iron Nov 5, 2024
@clalancette clalancette deleted the Crola1702/disable-test-qos branch November 5, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujitatomoya fujitatomoya fujitatomoya left review comments

@clalancette clalancette Awaiting requested review from clalancette

@Blast545 Blast545 Awaiting requested review from Blast545

@ivanpauno ivanpauno Awaiting requested review from ivanpauno ivanpauno is a code owner

@hidmic hidmic Awaiting requested review from hidmic hidmic is a code owner

@wjwwood wjwwood Awaiting requested review from wjwwood wjwwood is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Crola1702 @fujitatomoya @clalancette