Skip to content

Use the same context for the specified node in rclcpp::spin functions… (backport #2618)#2620

Merged
fujitatomoya merged 1 commit intohumblefrom
mergify/bp/humble/pr-2618
Sep 9, 2024
Merged

Use the same context for the specified node in rclcpp::spin functions… (backport #2618)#2620
fujitatomoya merged 1 commit intohumblefrom
mergify/bp/humble/pr-2618

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Sep 6, 2024

… (#2433)

This is backport of #2433 because of the code base difference.


This is an automatic backport of pull request #2618 done by Mergify.

#2618)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
(cherry picked from commit 531b2b1)
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good with green CI.

@fujitatomoya
Copy link
Copy Markdown
Collaborator

Pulls: #2620
Gist: https://gist.githubusercontent.com/fujitatomoya/91256dd3ba62d65abfdd0dc3a4ab7cf6/raw/0f7bb7f4da30997fc075252ed1ebe560a8488937/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14535

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator

@HansRobo FYI, this is humble backport, we can merge this with green CI.

Copy link
Copy Markdown
Contributor

@HansRobo HansRobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Looks good to me.

@fujitatomoya
Copy link
Copy Markdown
Collaborator

RHEL unstable failures https://ci.ros2.org/job/ci_linux-rhel/1314/testReport/ are unrelated to this fix.

@fujitatomoya fujitatomoya merged commit 9be01cf into humble Sep 9, 2024
@mergify mergify bot deleted the mergify/bp/humble/pr-2618 branch September 9, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants