Split test_executors.cpp even further. (backport #2572)#2619
Merged
clalancette merged 1 commit intojazzyfrom Sep 6, 2024
Merged
Split test_executors.cpp even further. (backport #2572)#2619clalancette merged 1 commit intojazzyfrom
clalancette merged 1 commit intojazzyfrom
Conversation
Contributor
Author
|
Cherry-pick of c743c17 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
That's because it is too large for Windows Debug to compile, so split into smaller bits. Even with this split, the file is too big; that's likely because we are using TYPED_TEST here, which generates multiple symbols per test case. To deal with this, without further breaking up the file, also add in the /bigobj flag when compiling on Windows Debug. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit c743c17)
35e6420 to
f22dc10
Compare
Contributor
|
Pulls: #2619
|
mjcarroll
approved these changes
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That's because it is too large for Windows Debug to compile, so split into smaller bits.
Even with this split, the file is too big; that's likely because we are using TYPED_TEST here, which generates multiple symbols per test case. To deal with this, without further breaking up the file, also add in the /bigobj flag when compiling on Windows Debug.
@Crola1702 FYI; this should fix osrf/buildfarm-tools#63 (comment)
This is an automatic backport of pull request #2572 done by Mergify.