Fix logging macros to build with msvc and cpp20 (backport #2063)#2529
Merged
fujitatomoya merged 1 commit intohumblefrom May 14, 2024
Merged
Fix logging macros to build with msvc and cpp20 (backport #2063)#2529fujitatomoya merged 1 commit intohumblefrom
fujitatomoya merged 1 commit intohumblefrom
Conversation
Signed-off-by: Mateusz Szczygielski <mateusz.szczygielski@robotec.ai> Signed-off-by: Mateusz Szczygielski <mateusz.szczygielski@robotec.ai> (cherry picked from commit 86335dd)
fujitatomoya
approved these changes
May 14, 2024
Collaborator
|
CI:
CC: @clalancette |
ahcorde
approved these changes
May 14, 2024
clalancette
approved these changes
May 14, 2024
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Looks reasonable to me; since it changes a static_assert, there should be no API/ABI considerations here.
Collaborator
|
windows failure is unrelated, https://ci.ros2.org/job/ci_windows/21794/. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was building my project (CMAKE_CXX_STANDARD 20) with rclcpp on Windows, it failed with the same error as described in #1973 (c++17 + permissive flag added to MSVC). The same flag is set implicitly with C++20 because is required for C++20 Modules support.
I was trying to investigate why the template in logging macro is not passing standards conformance, but I was not able to find it out. It seems to be an MSVC issue. A similar problem was reported in Microsoft Developer Community more than a year ago and has not been resolved yet.
I used helper type aliases from
type_traitsinstead of member types. This change makes rclcpp build successfully with MSVC and C++20.This is an automatic backport of pull request #2063 done by Mergify.