Nitpick: Minor grammar correction in node_parameters.cpp#2149
Merged
fujitatomoya merged 2 commits intorollingfrom Apr 3, 2023
Merged
Nitpick: Minor grammar correction in node_parameters.cpp#2149fujitatomoya merged 2 commits intorollingfrom
fujitatomoya merged 2 commits intorollingfrom
Conversation
Signed-off-by: Yadunund <yadunund@openrobotics.org>
alsora
approved these changes
Mar 31, 2023
Collaborator
|
CI:
|
Contributor
|
Since this is touching an exception that downstream consumers might see, here is a CI with
|
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 28, 2023
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Barry-Xu-2018
pushed a commit
to Barry-Xu-2018/rclcpp
that referenced
this pull request
Jan 12, 2024
Signed-off-by: Yadunund <yadunund@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.