Fix SharedFuture from async_send_request never becomes valid (backport #2044)#2076
Merged
fujitatomoya merged 1 commit intohumblefrom Jan 6, 2023
Merged
Fix SharedFuture from async_send_request never becomes valid (backport #2044)#2076fujitatomoya merged 1 commit intohumblefrom
fujitatomoya merged 1 commit intohumblefrom
Conversation
Signed-off-by: Lei Liu <Lei.Liu.AP@sony.com> (cherry picked from commit 66b1944)
fujitatomoya
approved these changes
Jan 3, 2023
Collaborator
|
CI:
|
Collaborator
|
CI again just in case:
|
fujitatomoya
reviewed
Jan 6, 2023
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
hmmm, i am not sure why CI is so unstable, i will retry CI once again.
Collaborator
|
CI only complains PEP 257 error for all platform, which are unrelated to this fix. Since everything else has green, i will go ahead to merge this. |
tkimura4
pushed a commit
to tier4/rclcpp
that referenced
this pull request
Aug 29, 2023
tkimura4
added a commit
to tier4/rclcpp
that referenced
this pull request
Aug 30, 2023
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2044 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com