Add in a fix for older compilers.#2075
Conversation
The addition of the NodeInterfaces class made it stop compiling with older compilers (such as gcc 9.4.0 on Ubuntu 20.04). The error has to do with calling the copy constructor on rclcpp::Node, which is deleted. Work around this by just getting rid of the nullptr check; it isn't actually needed, I don't think. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
It isn't necessary and was only good to have. Let's merge this I'm wondering why the error didn't show up on ci runs, sorry for the trouble! 🙇 |
|
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
CI:
|
|
The yellow builds are all due to PEP257, and will be fixed separately by ament/ament_lint#428 . Otherwise this looks clean. And here is RHEL: * RHEL |
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI
|
I have an approval, and green CI (modulo problems unrelated to this). I'm going to go ahead and merge this to unbreak RHEL; please leave any follow-up comments and I'll address them in a separate PR. |
…g changes from ros2#2075 Signed-off-by: Fabian Hirmann <f.hirmann@arti-robots.com>
The addition of the NodeInterfaces class made it stop compiling with older compilers (such as gcc 9.4.0 on Ubuntu 20.04). The error has to do with calling the copy constructor on rclcpp::Node, which is deleted. Work around this by just getting rid of the nullptr check; it isn't actually needed, I don't think.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
I'm honestly not sure that this is the best solution, but it definitely fixes the build on Ubuntu 20.04, and will likely fix the CI failures we are seeing in https://ci.ros2.org/view/nightly/job/nightly_linux-rhel_release/1370/ . I could use further feedback from @methylDragon and @wjwwood .