Make lifecycle impl get_current_state() const.#2031
Merged
clalancette merged 1 commit intorollingfrom Oct 24, 2022
Merged
Conversation
We should only need to update the current state when it changes, so we do that in the change_state method (which is not const). Then we can just return the current_state_ object in get_current_state, and then mark it as const. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Contributor
Author
|
CI:
|
alsora
approved these changes
Oct 24, 2022
Contributor
Author
|
Green CI and approved, so going ahead and merging this. Thanks for the review! |
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
sorry i was one step behind to review, a couple of minor comments.
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Mar 24, 2023
We should only need to update the current state when it changes, so we do that in the change_state method (which is not const). Then we can just return the current_state_ object in get_current_state, and then mark it as const. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Mar 24, 2023
We should only need to update the current state when it changes, so we do that in the change_state method (which is not const). Then we can just return the current_state_ object in get_current_state, and then mark it as const. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 29, 2023
We should only need to update the current state when it changes, so we do that in the change_state method (which is not const). Then we can just return the current_state_ object in get_current_state, and then mark it as const. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 29, 2023
We should only need to update the current state when it changes, so we do that in the change_state method (which is not const). Then we can just return the current_state_ object in get_current_state, and then mark it as const. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
May 3, 2023
We should only need to update the current state when it changes, so we do that in the change_state method (which is not const). Then we can just return the current_state_ object in get_current_state, and then mark it as const. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should only need to update the current state when it changes, so we do that in the change_state method (which is not const). Then we can just return the current_state_ object in get_current_state, and then mark it as const.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
@fujitatomoya FYI. Once we have this in, I think we can then rebase #1756 and it should make a lot more sense.