Skip to content

Revert "Add a create_timer method to Node and LifecycleNode classes (#1975)"#2009

Merged
sloretz merged 1 commit intorollingfrom
sloretz__revert_1975
Aug 30, 2022
Merged

Revert "Add a create_timer method to Node and LifecycleNode classes (#1975)"#2009
sloretz merged 1 commit intorollingfrom
sloretz__revert_1975

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Aug 30, 2022

This reverts #1975 because it seems to have caused a build error in tf2_ros.

#1975 (comment)

Next steps:

  • If the issue is a bug, then please open a PR again to rclcpp with a fix
  • If the issue is it changed an API used by tf2_ros, then please open a PR on rclcpp again plus open a PR on the geometry2 repo that updates its use of the API.

@asymingt + @ivanpauno + @jacobperron FYI

@sloretz
Revert "Add a create_timer method to Node and LifecycleNode cla…
cd1a4e8 
…sses (#1975)"

This reverts commit 6167a57.

Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Aug 30, 2022

CI (build: --packages-above-and-dependencies rclcpp test: --packages-select rclcpp)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette
Copy link
Copy Markdown
Contributor

clalancette commented Aug 30, 2022

  • If the issue is it changed an API used by tf2_ros, then please open a PR on rclcpp again plus open a PR on the geometry2 repo that updates its use of the API.

I'll further say that if we are breaking an API that tf2_ros is using, we should make sure to do a tick-tock deprecation cycle. Surely others will be using it as well.

@ivanpauno
Copy link
Copy Markdown
Member

ivanpauno commented Aug 30, 2022

I'll further say that if we are breaking an API that tf2_ros is using, we should make sure to do a tick-tock deprecation cycle. Surely others will be using it as well.

Sorry that was not an intentional change, the idea is to extend API without breaking it.

@sloretz sloretz merged commit 11b5f8d into rolling Aug 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the sloretz__revert_1975 branch August 30, 2022 20:42
@ivanpauno ivanpauno mentioned this pull request Aug 30, 2022
Merged
@sloretz sloretz mentioned this pull request Aug 30, 2022
Merged
ivanpauno added a commit that referenced this pull request Aug 30, 2022
@ivanpauno
Revert "Revert "Add a create_timer method to Node and `LifecycleN…
13a47fe 
…ode` classes (#1975)" (#2009)"

This reverts commit 11b5f8d.
ivanpauno added a commit that referenced this pull request Aug 30, 2022
@ivanpauno
Revert "Revert "Add a create_timer method to Node and `LifecycleN…
e1efffb 
…ode` classes (#1975)" (#2009)"

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

This reverts commit 11b5f8d.
ivanpauno added a commit that referenced this pull request Aug 31, 2022
@ivanpauno
Revert "Revert "Add a create_timer method to Node and LifecycleNode…
df994e4 
… classes (#1975)" (#2009) (#2010)

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sloretz @clalancette @ivanpauno @fujitatomoya