use regex for wildcard matching (backport #1839)#1986
Merged
fujitatomoya merged 2 commits intohumblefrom Sep 9, 2022
Merged
Conversation
* use regex for wildcard matching Co-authored-by: Aaron Lipinski <aaron.lipinski@roboticsplus.co.nz> Signed-off-by: Chen Lihui <lihui.chen@sony.com> * use map to process the content of parameter file by order Signed-off-by: Chen Lihui <lihui.chen@sony.com> * add more test cases Signed-off-by: Chen Lihui <lihui.chen@sony.com> * try to not decrease the performance and make the param win last Signed-off-by: Chen Lihui <lihui.chen@sony.com> * update node name Signed-off-by: Chen Lihui <lihui.chen@sony.com> * update document comment Signed-off-by: Chen Lihui <lihui.chen@sony.com> * add more test for parameter_map_from Signed-off-by: Chen Lihui <lihui.chen@sony.com> Co-authored-by: Aaron Lipinski <aaron.lipinski@roboticsplus.co.nz> (cherry picked from commit 6dd3a03)
fujitatomoya
approved these changes
Aug 10, 2022
Collaborator
|
@iuhilnehc-ynos requesting second review. |
iuhilnehc-ynos
approved these changes
Aug 10, 2022
ivanpauno
requested changes
Aug 10, 2022
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
ivanpauno
requested changes
Aug 16, 2022
Member
ivanpauno
left a comment
There was a problem hiding this comment.
Code LGTM, but we should only backport this when we have the equivalent feature supported in rclpy.
Member
|
@iuhilnehc-ynos @fujitatomoya could you confirm this is only extending the type of wildcards that were supported before and not adding any restrictions? But we should do that once both clients libraries support it, if not it's going to cause confusions. |
Collaborator
|
Could you help review ros2/rclpy#987? |
Collaborator
|
CI:
|
Collaborator
|
Windows CI is just unstable, unrelated. ready to merge. |
Collaborator
|
This needs to go in with ros2/rclpy#1002 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1839 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com