Fix returning invalid namespace if sub_namespace is empty (backport #1658)#1811
Merged
clalancette merged 1 commit intofoxyfrom Nov 11, 2021
Merged
Fix returning invalid namespace if sub_namespace is empty (backport #1658)#1811clalancette merged 1 commit intofoxyfrom
clalancette merged 1 commit intofoxyfrom
Conversation
* Create valid effective namespace when sub-namespace is empty Fix #1656. Signed-off-by: Markus Hofstaetter <markus.hofstaetter@ait.ac.at> * Add regression test for effective namespace and empty sub-namespace Adds regression test for #1656. Signed-off-by: Markus Hofstaetter <markus.hofstaetter@ait.ac.at> (cherry picked from commit 3cddb4e)
fujitatomoya
approved these changes
Oct 25, 2021
Collaborator
|
CC: @aprotyas |
aprotyas
approved these changes
Oct 25, 2021
Member
|
CI (build:
|
clalancette
approved these changes
Nov 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1658 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/