Update forward declarations of rcl_lifecycle types#1788
Merged
clalancette merged 2 commits intomasterfrom Sep 29, 2021
Merged
Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Contributor
Author
|
CI above
|
clalancette
reviewed
Sep 28, 2021
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
clalancette
approved these changes
Sep 28, 2021
Member
|
Nightlies + source builds are broken because ros2/rcl#938 was merged but this PR wasn't, e.g. https://ci.ros2.org/view/nightly/job/nightly_linux_release/2053/console#console-section-8 |
Contributor
Author
|
Argh! My bad. Merging! |
Contributor
Ug, good call. This seems to have built for me locally with this patch in place, so I'm going to go ahead and merge it without further CI; it can't be worse than the current state. |
Contributor
Author
|
You beat me to it @clalancette. Sorry for the fallout 🤦♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connected to ros2/rcl#938.