Fix up documentation build for rcl_lifecycle when using rosdoc2#938
Merged
Fix up documentation build for rcl_lifecycle when using rosdoc2#938
Conversation
* Handle RCL_WARN_UNUSED * Avoid duplicate type names Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
clalancette
approved these changes
Sep 21, 2021
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me with green CI.
Contributor
Author
|
CI above
|
Contributor
Author
|
I'll move forward with this one and release so we can get ros2/rclcpp#1788 to pass its Rpr job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #932.