Returns CancelResponse::REJECT while goal handle failed to transit to CANCELING state#1641
Merged
ivanpauno merged 3 commits intoros2:masterfrom Apr 30, 2021
Conversation
21ef267 to
07bef7b
Compare
Signed-off-by: Kaven Yau <kavenyau@foxmail.com>
39b0bdc to
a2634fa
Compare
Signed-off-by: Kaven Yau <kavenyau@foxmail.com>
a2634fa to
8cac085
Compare
fujitatomoya
approved these changes
Apr 27, 2021
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
looks good to me. i guess we could do backport for Galactic/Foxy w/o breaking ABI.
Collaborator
|
@ivanpauno @wjwwood @jacobperron could either of you take a look for another review when you got time? |
ivanpauno
reviewed
Apr 27, 2021
jacobperron
reviewed
Apr 27, 2021
Signed-off-by: Kaven Yau <kavenyau@foxmail.com>
0abe587 to
ecca6f7
Compare
6 tasks
jacobperron
approved these changes
Apr 30, 2021
Member
jacobperron
left a comment
There was a problem hiding this comment.
I think this is an improvement. Thanks for following up 👍
ivanpauno
approved these changes
Apr 30, 2021
Member
|
Adding it to the galactic board, I guess we want to backport this. |
Member
|
CI:
|
Member
|
@Mergifyio backport galactic |
Contributor
|
Command
|
This was referenced Apr 30, 2021
KavenYau
added a commit
to KavenYau/rclcpp
that referenced
this pull request
May 2, 2021
… CANCELING state (ros2#1641)
KavenYau
added a commit
to KavenYau/rclcpp
that referenced
this pull request
May 6, 2021
… CANCELING state (ros2#1641)
KavenYau
added a commit
to KavenYau/rclcpp
that referenced
this pull request
May 6, 2021
… CANCELING state (ros2#1641) Signed-off-by: Kaven Yau <kavenyau@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For fixing #1599. Some conversations in #1635 are helpful to this PR.