refactor executor::cancel to use a spinning state#155
Merged
jacquelinekay merged 1 commit intocancelfrom Nov 13, 2015
Merged
Conversation
Contributor
There was a problem hiding this comment.
Haha, I see you didn't find this comment every descriptive
Member
Author
There was a problem hiding this comment.
I've just been trying to be better about code docs in general. 😄
Contributor
|
Looks good at first glance. Can you add a test case, maybe in the other PR to system_tests, with two threads that try to enter |
Member
Author
|
Yup, but should I do it on the |
Contributor
|
Either is fine. |
Member
Author
|
I push a commit to this pr with the new tests: ros2/system_tests#73 (ros2/system_tests@3b346be) I'll leave it to you to merge this branch. |
jacquelinekay
added a commit
that referenced
this pull request
Nov 13, 2015
refactor executor::cancel to use a spinning state
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* ros2GH-155 Improve shared queue usage Add printouts of message queue size when refilling Print warning when starving * ros2GH-155 Extract method for readability * ros2GH-155 Fix replay timing when starved and improve warning message * Improve patching in vendor package
mauropasse
added a commit
to mauropasse/rclcpp
that referenced
this pull request
Aug 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jacquelinekay as we discussed off-line.