Use std compliant non-method std::filesystem::exists function#1502
Use std compliant non-method std::filesystem::exists function#1502clalancette merged 1 commit intoros2:masterfrom
Conversation
Signed-off-by: Josh Langsfeld <josh.langsfeld@gmail.com>
clalancette
left a comment
There was a problem hiding this comment.
Seems reasonable. I'll run CI on it next.
|
CI:
|
|
All right, CI looks good, so merging. Thanks for the contribution. |
|
Thanks! I'm not familiar with the procedure for getting stuff like this backported; what are the usual steps? Am I expected to take the lead on it? |
That's most expedient, yes. Though I'm not entirely sure this makes sense to backport. First, it is only in a test. And second, we won't be switching Foxy to C++17, so the fact that it isn't 100% compliant with |
|
It's really just so I don't have to keep around a forked version if combined with a modified Is the process just opening a PR against foxy with this commit cherry-picked on to a new branch? |
Yeah, that should do it for this PR. |
|
Ok thanks; if it looks like it will save some effort I'll go ahead with that, otherwise I won't bother you guys. |
I was looking into updating
rcpputils::fsto be more compliant withstd::filesystemfor an eventual C++17 migration and found the current functionality includes apath::exists()method which doesn't exist instd::filesystem. This simply changes usage to the non-member function and can be merged regardless of any future changes torcpputils.