Skip to content

[foxy] Add benchmarks for parameters#1470

Merged
cottsay merged 2 commits intofoxyfrom
cottsay/benchmark_backport
Nov 21, 2020
Merged

[foxy] Add benchmarks for parameters#1470
cottsay merged 2 commits intofoxyfrom
cottsay/benchmark_backport

Conversation

@cottsay
Copy link
Copy Markdown
Member

@cottsay cottsay commented Nov 19, 2020

Backport of #1444 and #1463 from Rolling to Foxy.

@cottsay cottsay added in review Waiting for review (Kanban column) tests Failing or missing tests labels Nov 19, 2020
@cottsay cottsay requested a review from brawner November 19, 2020 18:50
@cottsay cottsay self-assigned this Nov 19, 2020
Cherry-pick from dd0f97f

Signed-off-by: Scott K Logan <logans@cottsay.net>
Note that these tests are written without using
performance_test_fixture. Because the parameter server is running in the
same process, any allocations happening in the spin thread for the
server get picked up by the allocation statistics even though those
functions aren't invoked in the tests.

If we can find a way to turn off the memory tracking on a per-thread
basis, we can enable memory tracking. Until then, leaving the memory
statistics enabled could be misleading.

Cherry-picked from f5e35bd

Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay force-pushed the cottsay/benchmark_backport branch from 0a67daf to 0c9903f Compare November 19, 2020 18:51
@cottsay
Copy link
Copy Markdown
Member Author

cottsay commented Nov 20, 2020

@ros-pull-request-builder retest this please

@cottsay
Copy link
Copy Markdown
Member Author

cottsay commented Nov 20, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@cottsay
Copy link
Copy Markdown
Member Author

cottsay commented Nov 21, 2020

PR build is good, all of the noise in the CI builds occur upstream of this package. Merging.

@cottsay cottsay merged commit 3497650 into foxy Nov 21, 2020
cottsay added a commit that referenced this pull request Nov 21, 2020
Cherry-pick from dd0f97f

Signed-off-by: Scott K Logan <logans@cottsay.net>
@delete-merged-branch delete-merged-branch bot deleted the cottsay/benchmark_backport branch November 21, 2020 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in review Waiting for review (Kanban column) tests Failing or missing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants