[rclcpp_lifecycle] Change uint8_t iterator variables to size_t#1461
Merged
[rclcpp_lifecycle] Change uint8_t iterator variables to size_t#1461
Conversation
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Contributor
Author
|
Testing
|
Contributor
Given that states_size is defined as an |
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Contributor
Author
|
Sounds good, fixed. |
Contributor
Author
|
clalancette
approved these changes
Nov 17, 2020
jacobperron
pushed a commit
that referenced
this pull request
Dec 8, 2020
* Change uint8_t iterator variables to size_t Signed-off-by: Stephen Brawner <brawner@gmail.com> * Change to unsigned int Signed-off-by: Stephen Brawner <brawner@gmail.com>
jacobperron
added a commit
that referenced
this pull request
Dec 8, 2020
#1488) * Change uint8_t iterator variables to size_t Signed-off-by: Stephen Brawner <brawner@gmail.com> * Change to unsigned int Signed-off-by: Stephen Brawner <brawner@gmail.com> Co-authored-by: brawner <brawner@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small theoretical issue I found. The type of
states_sizeandtransitions_sizeisunsigned int, but the for loop int type isuint8_t. Whiledefault_state_machinehas only 11 states and 25 transitions, looping with a small integer type that is compared to a larger type could lead to an infinite loop. Whilesize_there is large enough to avoid problems, I'd also be happy to use alsounsigned int.Signed-off-by: Stephen Brawner brawner@gmail.com