[foxy backport] Parameterize test executors for all executor types (#1222) #1386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ahcorde
approved these changes
Oct 7, 2020
* Relocate test_executor to executors directory Signed-off-by: Stephen Brawner <brawner@gmail.com> * Parametrize test_executors for all executor types Signed-off-by: Stephen Brawner <brawner@gmail.com> * PR Fixup Signed-off-by: Stephen Brawner <brawner@gmail.com> * More fixup Signed-off-by: Stephen Brawner <brawner@gmail.com> * Fixup Signed-off-by: Stephen Brawner <brawner@gmail.com> * Adding issue for tracking Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
971190f to
e687f0f
Compare
Contributor
Author
|
Merging these into target branch so that #1383 can act as the ultimate feature branch. |
brawner
added a commit
that referenced
this pull request
Oct 19, 2020
…1222) (#1386) * Parameterize test executors for all executor types (#1222) * Relocate test_executor to executors directory Signed-off-by: Stephen Brawner <brawner@gmail.com> * Parametrize test_executors for all executor types Signed-off-by: Stephen Brawner <brawner@gmail.com> * PR Fixup Signed-off-by: Stephen Brawner <brawner@gmail.com> * More fixup Signed-off-by: Stephen Brawner <brawner@gmail.com> * Fixup Signed-off-by: Stephen Brawner <brawner@gmail.com> * Adding issue for tracking Signed-off-by: Stephen Brawner <brawner@gmail.com> * Remove tests for non-foxy API Signed-off-by: Stephen Brawner <brawner@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports
test_executors.cppand modifies the parametrized test to remove the tests for non-foxy API.