Increase test coverage of rclcpp_lifecycle to 96%#1298
Merged
Conversation
brawner
commented
Sep 10, 2020
| * \tparam ID Numerical identifier of the patch. Ought to be unique. | ||
| * \tparam ArgTx Argument types. | ||
| */ | ||
| template<size_t ID, typename ReturnT, |
Contributor
Author
There was a problem hiding this comment.
This is the only part of this file that's changed. It just adds the required overload.
9c2380c to
2b64712
Compare
2b64712 to
20c93d5
Compare
Blast545
reviewed
Sep 14, 2020
Contributor
Blast545
left a comment
There was a problem hiding this comment.
LGTM, left a couple of questions
hidmic
approved these changes
Sep 17, 2020
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Contributor
Author
|
Testing
|
Signed-off-by: Stephen Brawner <brawner@gmail.com>
6d6032d to
fe55d01
Compare
Contributor
Author
|
Once more, this time with feeling
|
Contributor
Author
|
All green. Rpr job has the cppcheck warning which requires a new release of mimick_vendor, otherwise it looks good. |
ahcorde
pushed a commit
that referenced
this pull request
Oct 22, 2020
* Increase test coverage of rclcpp_lifecycle to 96% Signed-off-by: Stephen Brawner <brawner@gmail.com> * PR Fixup Signed-off-by: Stephen Brawner <brawner@gmail.com> * test_depend Signed-off-by: Stephen Brawner <brawner@gmail.com> * rcutils test_depend Signed-off-by: Stephen Brawner <brawner@gmail.com> * More windows warnings Signed-off-by: Stephen Brawner <brawner@gmail.com>
ahcorde
pushed a commit
that referenced
this pull request
Nov 3, 2020
* Increase test coverage of rclcpp_lifecycle to 96% Signed-off-by: Stephen Brawner <brawner@gmail.com> * PR Fixup Signed-off-by: Stephen Brawner <brawner@gmail.com> * test_depend Signed-off-by: Stephen Brawner <brawner@gmail.com> * rcutils test_depend Signed-off-by: Stephen Brawner <brawner@gmail.com> * More windows warnings Signed-off-by: Stephen Brawner <brawner@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR increases the test coverage of rclcpp_lifecycle to about 96% across both the include and src directories.
It directly depends on #1297
patch.hppcontributes about 50% of the additions and that's pretty much unmodified except where indicated.Signed-off-by: Stephen Brawner brawner@gmail.com