Merged
Conversation
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Contributor
Author
|
Standard tests,
Cyclonedds only, where failure was demonstrated:
|
clalancette
requested changes
Sep 9, 2020
Contributor
clalancette
left a comment
There was a problem hiding this comment.
A couple of minor things to change here, but otherwise I like it.
Signed-off-by: Stephen Brawner <brawner@gmail.com>
clalancette
approved these changes
Sep 9, 2020
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me with green CI.
Contributor
Author
|
Testing cyclonedds rmw:
|
brawner
added a commit
that referenced
this pull request
Oct 5, 2020
* Remove rmw-dependent unit-test checks Signed-off-by: Stephen Brawner <brawner@gmail.com> * Address feedback Signed-off-by: Stephen Brawner <brawner@gmail.com> * PR Fixup Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
added a commit
that referenced
this pull request
Oct 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks some rmw-dependent checks made it into this unit test and has started showing up on build.ros2.org.
Example failure:
http://build.ros2.org/job/Fci__nightly-cyclonedds_ubuntu_focal_amd64/181/testReport/(root)/rclcpp_lifecycle/test_lifecycle_node_gtest_missing_result/
Signed-off-by: Stephen Brawner brawner@gmail.com