[dashing backport] Fix conversion of negative durations to messages (#1188)#1207
Merged
[dashing backport] Fix conversion of negative durations to messages (#1188)#1207
Conversation
ivanpauno
approved these changes
Jul 1, 2020
Member
ivanpauno
left a comment
There was a problem hiding this comment.
Thanks for doing the backport!
Contributor
Author
|
Alright, the extra warnings are due to the addition of |
Member
You can either backport #901 or delete the addition of the new warning. |
Contributor
Author
Contributor
Author
|
Depends on #1209. |
* Fix conversion from negative Duration or Time to the respective message type and throw in Duration::to_rmw_time() if the duration is negative. rmw_time_t cannot represent negative durations. Constructors and assignment operators can be just defaulted. Other changes are mainly cosmetical, to make conversions between signed and unsigned types and between 32-bit and 64-bit types more explicit. Signed-off-by: Johannes Meyer <johannes@intermodalics.eu> * Add -Wconversion compiler option and fix implicit conversions that might alter the value Signed-off-by: Johannes Meyer <johannes@intermodalics.eu> * Fix usage of fixture class in some unit tests by using gtest macro TEST_F() instead of TEST(). Signed-off-by: Johannes Meyer <johannes@intermodalics.eu> * Add compiler option -Wno-sign-conversion to fix build with Clang on macOS Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ef389e7 to
9481782
Compare
Contributor
Author
|
CI up
|
Contributor
Author
|
Test failures are unrelated to this patch. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rmw_time_t cannot represent negative durations.
Constructors and assignment operators can be just defaulted.
Other changes are mainly cosmetical, to make conversions between signed
and unsigned types and between 32-bit and 64-bit types more explicit.
Signed-off-by: Johannes Meyer johannes@intermodalics.eu
Signed-off-by: Johannes Meyer johannes@intermodalics.eu
Signed-off-by: Johannes Meyer johannes@intermodalics.eu
Signed-off-by: Johannes Meyer johannes@intermodalics.eu