Merged
Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
brawner
reviewed
Jun 2, 2020
brawner
reviewed
Jun 3, 2020
| // Was added to default group | ||
| shared_node->remove_waitable(fake_shared_ptr, nullptr); | ||
| } else { | ||
| // Was added to a specfic group |
Contributor
There was a problem hiding this comment.
Suggested change
| // Was added to a specfic group | |
| // Was added to a specific group |
brawner
approved these changes
Jun 3, 2020
Contributor
brawner
left a comment
There was a problem hiding this comment.
Looks good to me, if you can fix the couple of typos.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Contributor
Author
|
@jacobperron for approval. |
Blast545
reviewed
Jun 3, 2020
Blast545
approved these changes
Jun 3, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Blast545
approved these changes
Jun 3, 2020
jacobperron
approved these changes
Jun 3, 2020
Member
jacobperron
left a comment
There was a problem hiding this comment.
I only reviewed the changes to create_client.hpp and create_server.hpp (they LGTM).
Contributor
Author
|
Going in! |
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Jul 7, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde
pushed a commit
that referenced
this pull request
Oct 22, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde
pushed a commit
that referenced
this pull request
Oct 26, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further improvements on top of #1043.