Increasing test coverage of rclcpp_components#1044
Merged
brawner merged 4 commits intoros2:masterfrom May 12, 2020
Merged
Conversation
0bd1fa4 to
c4a409e
Compare
Contributor
Author
|
@ahcorde ping for review |
ahcorde
approved these changes
Apr 17, 2020
Contributor
Author
|
c4a409e to
2cc0379
Compare
Contributor
Author
|
Rebasing on master and removing the dependency on #1043
|
Contributor
Author
|
aarch-64 doesn't like my constructor throws exception test. I'll need to look into this one more. |
6fcdf78 to
3ea66c3
Compare
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Contributor
Author
|
Removed the throws test for now
|
Contributor
Author
|
Coverage: |
Contributor
Author
|
osX warnings exist already in nightlies. Also, build.ros2.org failure is not related and already existid prior to this PR. |
ahcorde
approved these changes
May 12, 2020
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Jul 7, 2020
* Increasing test coverage of rclcpp_components Signed-off-by: Stephen Brawner <brawner@gmail.com> * PR fixup Signed-off-by: Stephen Brawner <brawner@gmail.com> * Fixup Signed-off-by: Stephen Brawner <brawner@gmail.com> * Removing throws test for now Signed-off-by: Stephen Brawner <brawner@gmail.com>
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* Set to list: writer_choices: record.py Signed-off-by: EsipovPA <esipov.p@mail.ru> * Set to list: storage_choices: reindex.py Signed-off-by: EsipovPA <esipov.p@mail.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #1043, this adds tests to increase the test coverage of rclcpp_components as part of the effort to bring it to QL 1. This additions bring the coverage from 88% to 100% of the
includefiles and 95% of thesrcfiles (96% combined).Depends on #1043
New commit: 85193e6