Skip to content

[eloquent backport] Add missing service callback registration tracepoint (#986)#1004

Merged
ivanpauno merged 1 commit intoros2:eloquentfrom
christophebedard:backport-986
Feb 26, 2020
Merged

[eloquent backport] Add missing service callback registration tracepoint (#986)#1004
ivanpauno merged 1 commit intoros2:eloquentfrom
christophebedard:backport-986

Conversation

@christophebedard
Copy link
Copy Markdown
Member

Backport of #986 to Eloquent.

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@ivanpauno
Copy link
Copy Markdown
Member

@ros-pull-request-builder retest this please.

Copy link
Copy Markdown
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ivanpauno ivanpauno merged commit 9f2efa8 into ros2:eloquent Feb 26, 2020
@christophebedard christophebedard deleted the backport-986 branch February 26, 2020 17:13
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
* Add on play message callbacks to the `rosbag2::Player` class

Added new API
add_on_play_message_pre_callback(const play_msg_callback_t & callback)
add_on_play_message_post_callback(const play_msg_callback_t & callback)
delete_on_play_message_callback(const callback_handle_t & handle)

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Address warnings in Windows build

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Add note about order of calling when registered multiple callbacks

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants