Allow for implicitly convertable loggers as well (backport #2922) (backport #2936)#2937
Merged
fujitatomoya merged 1 commit intojazzyfrom Aug 19, 2025
Merged
Allow for implicitly convertable loggers as well (backport #2922) (backport #2936)#2937fujitatomoya merged 1 commit intojazzyfrom
fujitatomoya merged 1 commit intojazzyfrom
Conversation
Collaborator
|
Pulls: #2937
|
fujitatomoya
approved these changes
Aug 19, 2025
Collaborator
|
windows failures are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This way I can inherit from
rclpp::Loggerand still pass it to the logger macros.Is this user-facing behavior change?
Backwards compatible
Did you use Generative AI?
No
Additional Information
If accepted I would like to have this backported to active distros as well.
This is a manual backport of pull request #2922 done by @Timple.
This is an automatic backport of pull request #2936 done by Mergify.