Skip to content

introduce rcl_lifecycle_get_transition_label_by_id().#2827

Merged
fujitatomoya merged 1 commit intorollingfrom
fujitatomoya/introduce-rcl_lifecycle_get_transition_label_by_id
May 1, 2025
Merged

introduce rcl_lifecycle_get_transition_label_by_id().#2827
fujitatomoya merged 1 commit intorollingfrom
fujitatomoya/introduce-rcl_lifecycle_get_transition_label_by_id

Conversation

@fujitatomoya
Copy link
Copy Markdown
Collaborator

depends on ros2/rcl#1229

address ros2/rcl#991

Copy link
Copy Markdown
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will look up the transition map in the state machine, and return the corresponding string label based on the transition identification.

@fujitatomoya fujitatomoya requested a review from alsora April 28, 2025 20:49
@fujitatomoya fujitatomoya self-assigned this Apr 28, 2025
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

@alsora can you review this?

@alsora
Copy link
Copy Markdown
Collaborator

alsora commented Apr 30, 2025

CI for both this and ros2/rcl#1229

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

all test failure is unrelated to lifecycle.

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

@Mergifyio rebase

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 1, 2025

rebase

✅ Branch has been successfully rebased

@fujitatomoya fujitatomoya force-pushed the fujitatomoya/introduce-rcl_lifecycle_get_transition_label_by_id branch from b8ea3b1 to e3fe3e4 Compare May 1, 2025 20:12
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

No conflict, i will go ahead to merge this with ros2/rcl#1229

@fujitatomoya fujitatomoya merged commit 127a10e into rolling May 1, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants