introduce rcl_lifecycle_get_transition_label_by_id().#1229
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
left a comment
There was a problem hiding this comment.
I was originally going to deprecate rcl_lifecycle_get_transition_by_id, and look up the label based on the identification and call rcl_lifecycle_get_transition_by_label only. but we cannot do that, because id and label are not mapped identically in the transition map. (there can be same label for different identification)
so what we can do here is that introduce rcl_lifecycle_get_transition_label_by_id tries to get the label based on the identification from the transition map, and we still call rcl_lifecycle_get_transition_by_id with user specified id. with this, we can at least print the label based on the id as information.
since this bothers me a bit, i just went ahead to patch it for myself.
|
@alsora can you review this? |
part of #991