Adding in topic name to logging on IPC issues#2706
Merged
fujitatomoya merged 3 commits intorollingfrom Dec 14, 2024
Merged
Conversation
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
fujitatomoya
approved these changes
Dec 13, 2024
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI
mjcarroll
reviewed
Dec 13, 2024
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Collaborator
Author
|
@fujitatomoya CI is green now! |
Collaborator
|
Pulls: #2706
|
Collaborator
|
@SteveMacenski got it, just in case start CI for rclcpp package, i will merge it once it comes green. |
Collaborator
|
@Mergifyio backport humble jazzy |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 14, 2024
* Adding in topic name to logging on IPC issues Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update test matching output logging Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * adding in single quotes Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> (cherry picked from commit a13e16e)
mergify bot
pushed a commit
that referenced
this pull request
Dec 14, 2024
* Adding in topic name to logging on IPC issues Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update test matching output logging Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * adding in single quotes Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> (cherry picked from commit a13e16e)
This was referenced Dec 14, 2024
fujitatomoya
pushed a commit
that referenced
this pull request
Dec 14, 2024
* Adding in topic name to logging on IPC issues Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update test matching output logging Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * adding in single quotes Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> (cherry picked from commit a13e16e) Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
fujitatomoya
pushed a commit
that referenced
this pull request
Dec 14, 2024
* Adding in topic name to logging on IPC issues Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update test matching output logging Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * adding in single quotes Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> (cherry picked from commit a13e16e) Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables more introspection on "why" something failed so a user can fix it. Without this, migrating a node to IPC can be excruciatingly painful to find what of dozens of interfaces are having problems.
Addresses #2703