rmw_fastrtps supports service event gid uniqueness test.#2638
rmw_fastrtps supports service event gid uniqueness test.#2638clalancette merged 1 commit intorollingfrom
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
|
@clalancette @MiguelCompany can you review this? |
|
@fujitatomoya the rpr job failed because ros2/rmw_fastrtps#781 was not yet merged. |
|
@MiguelCompany thanks for the review.
i believe as long as CI is green, that is fine. I am not sure how often rpr system is rebased... i would like to check with rmw_zenoh before pushing this. @Yadunund is working on that, so do not want to bring another breaking trouble for them with this. |
|
@clalancette can you review and merge this? CC: @Yadunund i did confirm this test is passing with rmw_zenoh, see https://github.com/ros2/rclcpp/pull/2638/files#r1792386899 |
|
Pulls: #2638 |
|
@ros-pull-request-builder retest this please |
|
This is only a change in the rclcpp tests, so the Windows test failure must be unrelated. Going ahead and merging this one. |
part of ros2/rmw#357
this depends on ros2/rmw_fastrtps#781