Use client's reader guid for service introspection event gid.#781
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
left a comment
There was a problem hiding this comment.
@MiguelCompany what do you think about this change?
I am almost sure that using client's reader guid instead of writer guid here in the client for the service introspection event, will not affect any other behavior in rmw_fastrtps.
|
This is ok... if only using Should we consider the case of the server and the client using different vendors? I am ok with merging this, and addressing the cross-vendor case in a follow-up, but I would like @clalancette opinion first. |
|
atm, i think that is okay not to consider cross-vendor communication and current code does not seem to care about that either. (https://docs.ros.org/en/rolling/Concepts/Intermediate/About-Different-Middleware-Vendors.html#cross-vendor-communication) i understand we necessarily do not want to break that compatibility with this., but rosbag2 service problem
is much bigger problem happening right now... |
|
@clalancette @wjwwood what do you think? |
In fact, we would first need to have service interoperability between all the RMWs, which is currently not the case. Approved, and CI green, so I feel free to merge |
|
Did we run CI on RHEL Debug for this? That was the case that caused all of the problems before. |
|
All right, all looks happy with this. We'll see what happens overnight. |
part of ros2/rmw#357