Skip to content

Use the same context for the specified node in rclcpp::spin functions…#2618

Merged
ahcorde merged 2 commits intoironfrom
fujitatomoya/backport-rclcpp-pr-2433
Sep 6, 2024
Merged

Use the same context for the specified node in rclcpp::spin functions…#2618
ahcorde merged 2 commits intoironfrom
fujitatomoya/backport-rclcpp-pr-2433

Conversation

@fujitatomoya
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya commented Sep 3, 2024

… (#2433)

This is backport of #2433 because of the code base difference.

@fujitatomoya
Use the same context for the specified node in rclcpp::spin functions (…
e1ee31f 
…#2433)

This is backport of #2433 because of the code base difference.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@fujitatomoya fujitatomoya requested review from mjcarroll and removed request for hidmic, ivanpauno and wjwwood September 3, 2024 17:32
@fujitatomoya fujitatomoya mentioned this pull request Sep 3, 2024
Merged
fujitatomoya
fujitatomoya commented Sep 3, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of differences for this backport against original #2433.

  • since iron does not have rclcpp::spin_all, that fix is not included here.
  • besides that, corresponding test is removed accordingly.

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Sep 3, 2024

Pulls: #2618
Gist: https://gist.githubusercontent.com/fujitatomoya/6367152b3493400158386b147831b16b/raw/7abb55874d896098215d31fbe4fc5b842a33149b/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: iron
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14501

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

mjcarroll
mjcarroll reviewed Sep 3, 2024
View reviewed changes
ahcorde
ahcorde requested changes Sep 4, 2024
View reviewed changes
@fujitatomoya
address linter warnings.
f26b813 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Sep 4, 2024

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Sep 6, 2024

https://ci.ros2.org/job/ci_linux-rhel/1287/cmake/new/ is unrelated.

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Sep 6, 2024

@mjcarroll @ahcorde CI is green, could you review again?

@ahcorde ahcorde merged commit 531b2b1 into iron Sep 6, 2024
@ahcorde ahcorde deleted the fujitatomoya/backport-rclcpp-pr-2433 branch September 6, 2024 09:24
HansRobo
HansRobo approved these changes Sep 6, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@HansRobo HansRobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as the author of original PR.
Note: f26b813 is not included in original PR.

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Sep 6, 2024

@Mergifyio backport humble

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 6, 2024 •
edited
Loading

backport humble

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Sep 6, 2024
@fujitatomoya @mergify
Use the same context for the specified node in rclcpp::spin functions… (
ff2c35c 
#2618)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
(cherry picked from commit 531b2b1)
@mergify mergify bot mentioned this pull request Sep 6, 2024
Merged
fujitatomoya added a commit that referenced this pull request Sep 9, 2024
@mergify @fujitatomoya
Use the same context for the specified node in rclcpp::spin functions… (
9be01cf 
#2618) (#2620)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
(cherry picked from commit 531b2b1)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

+1 more reviewer

@HansRobo HansRobo HansRobo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fujitatomoya @mjcarroll @ahcorde @HansRobo