Fix name of ParameterEventHandler class in doc#2604
Merged
christophebedard merged 1 commit intorollingfrom Aug 18, 2024
Merged
Conversation
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
alsora
approved these changes
Aug 18, 2024
Member
Author
|
Since this only changes documentation/comments, I'll skip CI and just rely on the Rpr job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added in #1573, which is a fixed version of #829 (which was reverted in #1572).
The title of #1573/#829 mentions "ParameterEventsSubscriber" but there is no such class.
ParameterEventsSubscriberwas renamed toParameterEventHandler: 60533db + 894da98. These docs (and PR title) were just not updated.rclcpp::ParameterEventsSubscriber::get_parameter_from_event()doesn't exist, butrclcpp::ParameterEventHandler::get_parameter_from_event()does.