Split test_executors.cpp even further.#2572
Merged
clalancette merged 1 commit intorollingfrom Jul 2, 2024
Merged
Conversation
That's because it is too large for Windows Debug to compile, so split into smaller bits. Even with this split, the file is too big; that's likely because we are using TYPED_TEST here, which generates multiple symbols per test case. To deal with this, without further breaking up the file, also add in the /bigobj flag when compiling on Windows Debug. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Contributor
Author
|
CI:
|
alsora
approved these changes
Jul 2, 2024
fujitatomoya
approved these changes
Jul 2, 2024
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI
Contributor
Author
|
@Mergifyio backport jazzy |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
That's because it is too large for Windows Debug to compile, so split into smaller bits. Even with this split, the file is too big; that's likely because we are using TYPED_TEST here, which generates multiple symbols per test case. To deal with this, without further breaking up the file, also add in the /bigobj flag when compiling on Windows Debug. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit c743c17) # Conflicts: # rclcpp/test/rclcpp/executors/test_executors.cpp
clalancette
added a commit
that referenced
this pull request
Sep 4, 2024
That's because it is too large for Windows Debug to compile, so split into smaller bits. Even with this split, the file is too big; that's likely because we are using TYPED_TEST here, which generates multiple symbols per test case. To deal with this, without further breaking up the file, also add in the /bigobj flag when compiling on Windows Debug. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit c743c17)
clalancette
added a commit
that referenced
this pull request
Sep 6, 2024
That's because it is too large for Windows Debug to compile, so split into smaller bits. Even with this split, the file is too big; that's likely because we are using TYPED_TEST here, which generates multiple symbols per test case. To deal with this, without further breaking up the file, also add in the /bigobj flag when compiling on Windows Debug. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit c743c17) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That's because it is too large for Windows Debug to compile, so split into smaller bits.
Even with this split, the file is too big; that's likely because we are using TYPED_TEST here, which generates multiple symbols per test case. To deal with this, without further breaking up the file, also add in the /bigobj flag when compiling on Windows Debug.
@Crola1702 FYI; this should fix osrf/buildfarm-tools#63 (comment)