Bug report
Required Info:
- Operating System:
- Installation type:
- Version or commit hash:
- DDS implementation:
- Client library (if applicable):
Steps to reproduce issue
Remove the logic to skip the tests for spin_some_max_duration for the StaticSingleThreadedExecutor and EventsExecutor:
|
// TODO(wjwwood): The `StaticSingleThreadedExecutor` and the `EventsExecutor` |
|
// do not properly implement max_duration (it seems), so disable this test |
|
// for them in the meantime. |
|
if ( |
|
std::is_same<ExecutorType, rclcpp::executors::StaticSingleThreadedExecutor>() || |
|
std::is_same<ExecutorType, rclcpp::experimental::executors::EventsExecutor>()) |
|
{ |
|
GTEST_SKIP(); |
|
} |
Run the test and see that they fail.
Expected behavior
The tests should pass as they are testing expected and documented behavior for spin_some.
Actual behavior
Tests fail.
Additional information
See also: #2460
Bug report
Required Info:
Steps to reproduce issue
Remove the logic to skip the tests for
spin_some_max_durationfor theStaticSingleThreadedExecutorandEventsExecutor:rclcpp/rclcpp/test/rclcpp/executors/test_executors.cpp
Lines 574 to 582 in a85382a
Run the test and see that they fail.
Expected behavior
The tests should pass as they are testing expected and documented behavior for
spin_some.Actual behavior
Tests fail.
Additional information
See also: #2460