max_duration not respected in spin_some for StaticSingleThreadedExecutor and EventsExecutor #2462
Description
Bug report
Required Info:
- Operating System:
- Linux
- Installation type:
- Source
- Version or commit hash:
- Rolling
- DDS implementation:
- Any
- Client library (if applicable):
- rclcpp
Steps to reproduce issue
Remove the logic to skip the tests for spin_some_max_duration for the StaticSingleThreadedExecutor and EventsExecutor:
rclcpp/rclcpp/test/rclcpp/executors/test_executors.cpp
Lines 574 to 582 in a85382a
Run the test and see that they fail.
Expected behavior
The tests should pass as they are testing expected and documented behavior for spin_some.
Actual behavior
Tests fail.
Additional information
See also: #2460