Remove deprecated header scope_exit.hpp#2139
Conversation
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
|
Thanks for taking care of it! I saw the TODO a few months ago, but proceeded to forget about it once again 😆 |
|
My pleasure - I really like deleting code 😁 |
One of my proudest moments was a PR which was like +10, -10000 :). As far as this PR is concerned, this is fine and we are fairly confident that the core has no uses (otherwise CI would have been yellow). But we don't know whether that is the case for the larger ecosystem. So I'm going to request we hold off on merging this one until we open a release note for it. I'm happy to do that, but I first want to get ros2/ros2_documentation#3395 landed. |
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me with green CI and assuming ros2/ros2_documentation#3402 gets merged at the same time.
|
Gist: https://gist.githubusercontent.com/emersonknapp/37a24cfacf9a38830166bd1dee724f5d/raw/dca003635973b67f2a0738ab71af708e3ef993f6/ros2.repos
|
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
It was deprecated in H for removal in I
@christophebedard